-
Notifications
You must be signed in to change notification settings - Fork 443
chore: move rules_js to bzlmod #5072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
All contributors have signed the CLA ✍️ ✅ |
Changes so far look good – make sure to remove the workspace imports of {rules_js, rules_ts, rules_esbuild, rules_nodejs} while we're adding the though – just grep the |
@fhanau done - I think the windows timeout is a flake, should I increase the timeout for that target? |
This keeps timing out even after re-running – yeah, increasing the timeout might be needed here. |
7d2efe4
to
9eb663e
Compare
The generated output of |
Hi @fhanau this is green now, do you want to keep the timeout bump from 1min to 3min? |
Note that the parameter is based on n seconds, not minutes. I don't think it matters much (we don't use small-sized tests much) but 1s does sound too short so let's keep it. |
@fhanau can you check the red internal build? It was green before my last commit, so I don't see how I could have broken it. |
Try to rebase off main. There is a failing workerd test with the downstream build, which is confusing since none of the files changed here are used by the downstream build. |
511d691
to
3051d5a
Compare
No description provided.