Skip to content

Conversation

alexeagle
Copy link
Collaborator

No description provided.

@alexeagle alexeagle requested a review from fhanau September 13, 2025 00:03
@alexeagle alexeagle requested review from a team as code owners September 13, 2025 00:03
Copy link

github-actions bot commented Sep 13, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@fhanau
Copy link
Contributor

fhanau commented Sep 13, 2025

Changes so far look good – make sure to remove the workspace imports of {rules_js, rules_ts, rules_esbuild, rules_nodejs} while we're adding the though – just grep the build/deps folder.

@alexeagle
Copy link
Collaborator Author

@fhanau done - I think the windows timeout is a flake, should I increase the timeout for that target?

@fhanau
Copy link
Contributor

fhanau commented Sep 16, 2025

@fhanau done - I think the windows timeout is a flake, should I increase the timeout for that target?

This keeps timing out even after re-running – yeah, increasing the timeout might be needed here.

@alexeagle alexeagle force-pushed the alexeagle/bzlmod_rulesjs branch 2 times, most recently from 7d2efe4 to 9eb663e Compare September 23, 2025 13:31
Copy link

github-actions bot commented Sep 23, 2025

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@alexeagle
Copy link
Collaborator Author

Hi @fhanau this is green now, do you want to keep the timeout bump from 1min to 3min?

@fhanau
Copy link
Contributor

fhanau commented Sep 23, 2025

Hi @fhanau this is green now, do you want to keep the timeout bump from 1min to 3min?

Note that the parameter is based on n seconds, not minutes. I don't think it matters much (we don't use small-sized tests much) but 1s does sound too short so let's keep it.

@alexeagle
Copy link
Collaborator Author

@fhanau can you check the red internal build? It was green before my last commit, so I don't see how I could have broken it.

@fhanau
Copy link
Contributor

fhanau commented Sep 23, 2025

@fhanau can you check the red internal build? It was green before my last commit, so I don't see how I could have broken it.

Try to rebase off main. There is a failing workerd test with the downstream build, which is confusing since none of the files changed here are used by the downstream build. Only theory I have is that it didn't rebase this branch properly when running the internal-build job, so being on top of main may help? actually it's because this ran with a workerd change that requires an internal change that wasn't included yet when the job ran – any push to this should fix it.
Sorry that this keeps failing in confusing ways btw.

@alexeagle alexeagle force-pushed the alexeagle/bzlmod_rulesjs branch from 511d691 to 3051d5a Compare September 24, 2025 13:17
@alexeagle alexeagle merged commit 7b7f887 into main Sep 24, 2025
21 checks passed
@alexeagle alexeagle deleted the alexeagle/bzlmod_rulesjs branch September 24, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants