fix: Other protocols allowed before socket2fetcher #4814
Merged
+63
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tewaro
commented
Aug 18, 2025
tewaro
commented
- Ignore disturbed for both readable and writable
- Adds test to ensure previous protocol doesn't interrupt conversion.
|
The generated output of |
- Ignore disturbed for both readable and writable - Adds test to ensure previous protocol doesn't interrupt conversion.
tewaro
force-pushed
the
tewaro/other-protocols-allowed-socket2fetcher
branch
from
b732fa4 to
7508d5b
Compare
jasnell
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.