Skip to content

More refinement of webfs impl #4584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2025
Merged

More refinement of webfs impl #4584

merged 2 commits into from
Jul 22, 2025

Conversation

jasnell
Copy link
Collaborator

@jasnell jasnell commented Jul 21, 2025

Reworks the Webfs implementation to be more correct and pass more of the WPT's.

Simplifies things a bit by removing the sync fs api for now (we can add it back in later)

@jasnell jasnell requested review from a team as code owners July 21, 2025 17:19
@jasnell jasnell requested a review from a team July 21, 2025 17:19
Copy link

github-actions bot commented Jul 21, 2025

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@jasnell jasnell marked this pull request as draft July 21, 2025 17:44
@jasnell

This comment was marked as resolved.

@jasnell

This comment was marked as resolved.

@jasnell jasnell force-pushed the jasnell/webfs-continued-work branch from cafb93f to d795458 Compare July 22, 2025 16:16
@jasnell jasnell marked this pull request as ready for review July 22, 2025 16:16
@jasnell
Copy link
Collaborator Author

jasnell commented Jul 22, 2025

Btw, the biggest change here is that the WebFs classes no longer directly hold the kj::Rc<...> for the underlying fs node and instead will look it up each time an operation is called... which is what the spec actually expects. Per the spec, and per the tests, it is actually possible to acquire a handle for a node, have that node be deleted and recreated, and the handle would still be viable/usable. The prior implementation failed that expectation.

This also still isn't perfect, as there are a few other bits in here that need to be fixed, but I'm trying to go through these in smaller, more consumable/reviewable chunks rather than all at once.

This comment has been minimized.

@jasnell jasnell enabled auto-merge (squash) July 22, 2025 21:07
@jasnell jasnell merged commit 2206fef into main Jul 22, 2025
21 of 23 checks passed
@jasnell jasnell deleted the jasnell/webfs-continued-work branch July 22, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants