Re-merge Request.signal PR #3923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npaun
force-pushed
the
npaun/re-request-signal
branch
2 times, most recently
from
1dba8ef to
5f2eb65
Compare
|
The generated output of |
npaun
force-pushed
the
npaun/re-request-signal
branch
from
5f2eb65 to
31af0d4
Compare
anonrig
approved these changes
Apr 10, 2025
npaun
force-pushed
the
npaun/re-request-signal
branch
from
3c652d8 to
8c43ca7
Compare
npaun
force-pushed
the
npaun/re-request-signal
branch
from
8c43ca7 to
0372ef2
Compare
npaun
force-pushed
the
npaun/re-request-signal
branch
from
0372ef2 to
fcb2b40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-enables the support for
Request.signalon incoming requests that I originally added in #3488 and #3727. These changes were originally reviewed and approved in those PRs.However, these changes caused a regression in production and had to be reverted in #3735. AbortSignals were never cloneable, and trying to clone any Request with the
signalproperty set would fail. But with my PR, thesignalproperty was now always set in a very common case, the request received by a worker in its fetch handler.AbortSignal will now be cloneable once #3922 is merged. The second commit to this PR adds a regression test which now fails but will work once #3922 is merged.