Allow sendmmsg to carry an extra payload added to every msg - #2580
Open
nmldiegues wants to merge 1 commit into
Open
Allow sendmmsg to carry an extra payload added to every msg#2580nmldiegues wants to merge 1 commit into
nmldiegues wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
sendmmsg_with_suffix, a variant ofsendmmsgthat appends acaller-supplied suffix (e.g. shared framing) to every datagram in the
batch using an extra
iovecper message, avoiding a copy into acombined buffer.
Fix two latent bugs in
sendmmsgalong the way:would discard the last OS error and silently report success.
MAX_MMSGinstead of the current chunk's length, so the last (possibly
shorter) chunk never triggered early exit.
Ok(0)instead of hittingmsgvecwith no capacity.
iovecsis fully populated before anymmsghdr.msg_iovpointers aretaken, per the safety invariant documented in
mmsg.rs/AGENTS.md,preventing dangling pointers from a
SmallVecreallocation.Renames the
sendmmsgtest tosend_manyand adds coverage for thenew suffix path, empty batches, and error propagation without
progress.