Strip hop-by-hop headers in H1 upstream proxy#734
Open
nbarbier-265 wants to merge 3 commits intocloudflare:mainfrom
Open
Strip hop-by-hop headers in H1 upstream proxy#734nbarbier-265 wants to merge 3 commits intocloudflare:mainfrom
nbarbier-265 wants to merge 3 commits intocloudflare:mainfrom
Conversation
Per RFC 2616 Section 13.5.1, proxies must not forward hop-by-hop headers to upstream servers. This change adds header stripping for the H1 proxy path, matching the behavior already implemented for H2. Headers stripped: - Connection - Keep-Alive - Proxy-Connection - Proxy-Authenticate - Proxy-Authorization - TE - Trailer - Upgrade Fixes cloudflare#706
Websocket upgrades require Connection and Upgrade headers to establish the upgrade handshake. Only strip hop-by-hop headers for non-upgrade HTTP/1.1 requests. This fixes test_ws_server_ends_conn which was failing due to missing Connection: Upgrade header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per RFC 2616 Section 13.5.1, proxies must not forward hop-by-hop headers to upstream servers. This change adds header stripping for the H1 proxy path, matching the behavior already implemented for H2.
Headers stripped:
Fixes #706