Skip to content
This repository was archived by the owner on Sep 29, 2025. It is now read-only.

Conversation

@yoohahn
Copy link

@yoohahn yoohahn commented Mar 3, 2025

This aims to fix #945
When the middleware response is being processed we do not always add the status code of that response to the RouteMatchers.status.

With this pr it is added for all responses that has the header x-middleware-rewrite.

But why do we not always set this.status to be equal to resp.status?

@changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2025

⚠️ No Changeset found

Latest commit: 4a49136

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dario-piotrowicz
Copy link
Member

Thank you very much for the PR (and sorry for the late reply here 🙇).

Earlier this year we released our Cloudflare adapter for OpenNext, and we have been continuously investing effort in its improvement since then. The Cloudflare adapter for OpenNext is currently stable and recommended for deployment of Next.js applications to Cloudflare. As such, we will no longer be maintaining next-on-pages. We recently deprecated the package on npm and we plan to archive this repo on Monday Sep 29, 2025. In preparation for archival, we are closing all open issues and PRs.

If you have concerns, please feel free to reply here before the repo is archived (after that, it will no longer be possible to comment) or to reach out to our team on Discord.

Thank you so much for using and contributing to next-on-pages 🧡

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: status code does not match what is set in rewrite

2 participants