Fix prerendered dynamic ISR functions with catch-all segments #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 64e4d8a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
🧪 Prereleases are available for testing 🧪 @cloudflare/next-on-pagesYou can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/10563926855/npm-package-next-on-pages-864@cloudflare/eslint-plugin-next-on-pagesYou can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/10563926855/npm-package-eslint-plugin-next-on-pages-864 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands on the change in #834 to fix prerendered routes with catch-all (e.g. blog/[...slug]/page.tsx -> blog/foo and blog/category/bar) routes.
I ran into an issue trying to get timlrx/tailwind-nextjs-starter-blog working on Cloudflare Pages. For the most part, everything worked, but for blog posts in particular, there were two issues: first, somewhere in the stack code is
eval-ed, so posts cannot be rendered on the edge runtime and must be prerendered. The second: next-on-pages wasn't doing whatever magic it usually does for a typical blog/[slog]/page.tsx, so I was getting an error telling me to addruntime = 'edge'.This change applies the same fix to
[...param]routes as it does[param]routes. I readily admit, I am a backend developer/data engineer not familiar with this codebase, Next.js, Cloudflare Pages, etc. This is working for me, but please validate my assumptions before merging.I released this package on @benmanns/next-on-pages if anyone (like me) wants to use the changes immediately.