Skip to content

add wrangler3 peer dependency #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2023

Conversation

dario-piotrowicz
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented May 18, 2023

🦋 Changeset detected

Latest commit: cb56720

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/next-on-pages Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2023

🧪 A prerelease is available for testing 🧪

You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/5013179908/npm-package-next-on-pages-259

Or you can immediately run this with npx:

npx https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/5013179908/npm-package-next-on-pages-259

Copy link
Collaborator

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this version of next-on-pages still work with 2.20?
If so, do we need to force bump people to 3.0.0?

@dario-piotrowicz
Copy link
Member Author

dario-piotrowicz commented May 18, 2023

Would this version of next-on-pages still work with 2.20? If so, do we need to force bump people to 3.0.0?

No it doesn't work with 2.20, we do need to force 3.0.0 😓


In 2.20.0 it has that issue that the lazy loaded files aren't copied over:
Screenshot 2023-05-18 at 16 20 41

(so wrangler pages dev does not work properly)

(and I also think that wrangler pages publish had some issues, but I might be wrong, anyways it's all good with wrangler v3)

@petebacondarwin petebacondarwin merged commit 3f05e81 into cloudflare:main May 18, 2023
@dario-piotrowicz dario-piotrowicz deleted the wrangler3 branch May 18, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants