fix: validate duplicate track_alias in recv_subscribe_ok #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per draft-ietf-moq-transport-14, if a track_alias is already in use for a different subscription, the session must be closed with DUPLICATE_TRACK_ALIAS error (0x5). Previously, the code would silently overwrite the existing track_alias mapping, which could cause streams/datagrams to be routed to the wrong subscription. Now checks if the track_alias already exists in the alias map and returns SessionError::Duplicate if it maps to a different subscribe_id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per draft-ietf-moq-transport-14, if a track_alias is already in use for a different subscription, the session must be closed with DUPLICATE_TRACK_ALIAS error (0x5).
Previously, the code would silently overwrite the existing track_alias mapping, which could cause streams/datagrams to be routed to the wrong subscription.
Now checks if the track_alias already exists in the alias map and returns SessionError::Duplicate if it maps to a different subscribe_id.