-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: update docs to represent v3 #733
Conversation
admah
commented
Oct 31, 2023
•
edited
Loading
edited
- removes CLI refs from config tabs
- removes content related to MF v1
- removes content that isn't relevant to v3 (eg. mounts)
- removes refs to deprecated/removed methods and functionality
…to wrangler 1. other cleanup.
|
@mrbbot a couple of things:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for doing this! 🥳 I've added a bunch of comments. In response to your questions:
the Queues page is new and I don't know what content should go in there. Any help is greatly appreciated!
I've added some comments inline.
should I make all the examples show module syntax and SW syntax?
I don't think we need to show both in all examples, but having a least one example of SW syntax somehwere would be good.
I removed refs to miniflare/storage-redis. Does that package no longer exist?
Yep, that package was Miniflare 2 only.
Co-authored-by: MrBBot <bcoll@cloudflare.com>
Co-authored-by: MrBBot <bcoll@cloudflare.com>
Co-authored-by: MrBBot <bcoll@cloudflare.com>
Co-authored-by: MrBBot <bcoll@cloudflare.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those changes. It looks like there are still some unresolved comments in docs/src/content/get-started/index.md
, and I've added one more minor thing, but other than that, looks good! 👍
Co-authored-by: MrBBot <bcoll@cloudflare.com>
Co-authored-by: MrBBot <bcoll@cloudflare.com>
Co-authored-by: MrBBot <bcoll@cloudflare.com>
Co-authored-by: MrBBot <bcoll@cloudflare.com>
Co-authored-by: MrBBot <bcoll@cloudflare.com>
Co-authored-by: MrBBot <bcoll@cloudflare.com>
Co-authored-by: MrBBot <bcoll@cloudflare.com>
Co-authored-by: MrBBot <bcoll@cloudflare.com>
Co-authored-by: MrBBot <bcoll@cloudflare.com>
Co-authored-by: MrBBot <bcoll@cloudflare.com>
Co-authored-by: MrBBot <bcoll@cloudflare.com>
Co-authored-by: MrBBot <bcoll@cloudflare.com>
Co-authored-by: MrBBot <bcoll@cloudflare.com>
Thanks @mrbbot! I have resolved all open comments and committed that last change you made 👍 |