fix(auth): derive scope labels from catalog names - #200
Open
mattzcarey wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nameinstead of rebuilding product names from scope IDsMoQ@cloudflare/workers-oauth-providerfrom 0.10.2 to the latest release, 0.10.3Compatibility checks
Production Worker version 118 currently bundles workers-oauth-provider 0.10.2. Version 0.10.3 scopes default CIMD grant revocation to the authorizing redirect URI; it does not change authorization-response issuer behavior.
I also exercised the newest ChatGPT desktop build downloaded by Sparkle (
26.803.81509, Codex CLI0.147.0-alpha.6.6) against a local RFC 9207 fixture:iss: authorization completed and the token endpoint received one requestiss: authorization failed and the token endpoint received no requestThis confirms the latest desktop client's
issvalidation works with the issuer response emitted by this server.Verification
npm run check(281 tests)