Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Github actions - added macOS,Windows + cron #48

Merged

Conversation

IgnorantSapient
Copy link

@IgnorantSapient IgnorantSapient commented Jul 12, 2022

We run into issues like #45 where the CLI tool breaks for one particular OS and it is due to a bug down the dependency tree.

In order to avoid issues like this @jagger27 has made some good fixes like #43 and #40. In this PR I have

  1. Added MacOs and Windows to ensure cross-platform compatibility (And to catch occurrences like Package not installing on Mac  #45).
  2. Set the pipeline to run weekly on Tuesdays to notify the maintainer about failures.
  3. Trimmed the string 'Test' from the name of the build stage to improve readability(The name of the tests got too long).

Tested extensively here on my fork https://github.com/IgnorantSapient/gokey/actions/runs/2659679942

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@IgnorantSapient IgnorantSapient force-pushed the github-actions-improvements branch 2 times, most recently from 259318b to 3131f4f Compare July 13, 2022 20:25
@ignatk ignatk merged commit 657b7cb into cloudflare:master Jul 13, 2022
@ignatk
Copy link
Contributor

ignatk commented Jul 13, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants