Repository navigation
Make just-bash and acorn optional peer dependencies, pulled in only by the backend that needs them #220
Description
Activity
Thanks for the proposal. It asks to move
just-bashandacorn(and possiblycapnweb) fromdependenciesto optionalpeerDependenciesin@cloudflare/computer. It also asks for README/Installation docs and a clear error when a backend's peer is missing. The likely area ispackages/computer/package.json, plusbackends/worker-shellandbackends/worker-javascript. I found no duplicate open issues.@gardener-cf can you pick up this issue and write up a short implementation proposal with summary of actual package size savings.
Reacted by github-actions@aron-cf I propose optional peers for
just-bash/acorn, retaining devDependencies; externalize acorn (currently bundled), document backend installs, replace eager imports with guarded lazy loading, and test absent/present peers plus filesystem-only consumers. Keepcapnweb: core Workspace eagerly imports its RpcTarget through WorkspaceStub.Measured locked versions: just-bash 3.2.0 = 22,280,274 unpacked bytes; acorn 8.18.0 = 565,327. Combined direct-package savings: 21.79 MiB unpacked / 9.45 MiB compressed downloads, when neither is otherwise required; transitive savings excluded. This is installation savings, not guaranteed Worker-bundle or Computer-tarball savings: prebuilt shell payloads remain.
The issue body requests implementation; I’m treating that as proposal context, not authorization to change code. This run proposes only this write-up.
@cloudflare/computerlistsacornandjust-bashindependencies. Every consumer installs them, including ones that only use the filesystem, git, or the container backend:just-bashis imported only by the worker-shell backend (backends/worker-shell/*).acornis imported only by the worker-javascript backend (backends/worker-javascript/module-graph.ts).Those backends ship as separate subpath entries, so a bundler drops the code when it isn't imported. The packages still get installed and resolved, and they land in the lockfile. That matters for packages that build on Computer. We want
@cloudflare/thinkin cloudflare/agents to default to a Computer Workspace, and Think users shouldn't pull in a shell interpreter or a JS parser they never run.Proposal
just-bashandacorntopeerDependenciesand mark themoptionalinpeerDependenciesMeta, the same patternai,zod, and@platformatic/vfsalready follow.backends/worker-shellneedsjust-bashandbackends/worker-javascriptneedsacorn.capnwebcan go the same way for consumers that never use the container backend or the remote client.