Skip to content

Conversation

@alyssamw
Copy link

Description

Add new teams rule setting field, "untrusted_cert". This is an object containing an "action" field which can have 3 values: pass_through, block, or error.

Ignore commit 7e6a0e7 which is being used for terraform-provider PR -- will delete before merging

Has your change been tested?

Updated the serialization tests, nothing else to test here.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • [ x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [ x ] I have added tests to cover my changes.
  • [ x ] All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@github-actions
Copy link

github-actions bot commented Feb 22, 2023

changelog detected ✅

@alyssamw
Copy link
Author

alyssamw commented Feb 23, 2023

API docs are pending internal release

@jacobbednarz
Copy link
Contributor

thanks! this all looks good. i'll circle back once we have the API docs sorted 😃

@alyssamw
Copy link
Author

alyssamw commented Feb 27, 2023

Hi Jacob, the docs got released on https://developers.cloudflare.com/api/operations/zero-trust-gateway-rules-create-zero-trust-gateway-rule, could I get this PR merged?

Edit: new commit fixes merge conflicts, lint errors

@jacobbednarz jacobbednarz merged commit ebd7750 into cloudflare:master Feb 27, 2023
@jacobbednarz
Copy link
Contributor

thanks @alyssamw 🏆

@github-actions github-actions bot added this to the v0.62.0 milestone Feb 27, 2023
github-actions bot pushed a commit that referenced this pull request Feb 27, 2023
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

This functionality has been released in v0.62.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants