Skip to content

Conversation

@nikitassharma
Copy link
Member

Summary

Screenshots (optional)

Documentation checklist

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

This PR requires additional review attention because it affects the following areas:

Partials

This PR updates partial files, which are pieces of content used across multiple files in our Render component.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/src/content/docs/containers/ @mikenomitch, @th0m, @cloudflare/pcx-technical-writing, @cloudflare/cloudchamber
/src/content/partials/workers/ @cloudflare/workers-docs, @GregBrimble, @irvinebroque, @mikenomitch, @WalshyDev, @cloudflare/deploy-config, @cloudflare/pcx-technical-writing, @kodster28, @cloudflare/wrangler, @cloudflare/workers-runtime-1

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

// arn:${Partition}:ecr:${Region}:${Account}:repository/${Repository-name}
"Resource": [
"arn:aws:ecr:us-east-1:123456789012:repository/my-repo",
"arn:aws:ecr:us-east-1:123456789012:repository/my-second-repo"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs say "with the following" policy, but this is referencing specific images.

I think we need to rephrase above to show that this is an example.

And/or remove the specific images from this and leave a commented out section referring to a specific image (but keep the splat)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to be more explicit in the documentation. Also changed the policy to default to the splat and left the specific image as a commented out example

Copy link
Contributor

@mikenomitch mikenomitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1ing to unblock you, but some comments that we should address

nikitassharma and others added 2 commits November 7, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants