-
Notifications
You must be signed in to change notification settings - Fork 9.9k
containers: add documentation for using external image registries #26364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: production
Are you sure you want to change the base?
Conversation
|
This PR requires additional review attention because it affects the following areas: PartialsThis PR updates partial files, which are pieces of content used across multiple files in our Render component.
|
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
|
Preview URL: https://3d1d2dc8.preview.developers.cloudflare.com Files with changes (up to 15) |
src/content/docs/containers/platform-details/image-management.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/containers/platform-details/image-management.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/containers/platform-details/image-management.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/containers/platform-details/image-management.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/containers/platform-details/image-management.mdx
Outdated
Show resolved
Hide resolved
| // arn:${Partition}:ecr:${Region}:${Account}:repository/${Repository-name} | ||
| "Resource": [ | ||
| "arn:aws:ecr:us-east-1:123456789012:repository/my-repo", | ||
| "arn:aws:ecr:us-east-1:123456789012:repository/my-second-repo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs say "with the following" policy, but this is referencing specific images.
I think we need to rephrase above to show that this is an example.
And/or remove the specific images from this and leave a commented out section referring to a specific image (but keep the splat)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to be more explicit in the documentation. Also changed the policy to default to the splat and left the specific image as a commented out example
mikenomitch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1ing to unblock you, but some comments that we should address
Co-authored-by: Mike Nomitch <mnomitch@cloudflare.com>
Summary
Screenshots (optional)
Documentation checklist