Updates Python Workers examples to use new Python SDK API #18596
Conversation
dom96
requested review from
GregBrimble,
irvinebroque,
mikenomitch,
WalshyDev,
ToriLindsay,
a team,
elithrar,
rozenmd,
vy-ton,
joshthoward and
Oxyjun
as code owners
github-actions
bot
added
product:d1
github-actions
bot
assigned elithrar, joshthoward, Oxyjun, rozenmd, vy-ton, GregBrimble, irvinebroque, mikenomitch, ToriLindsay and WalshyDev
Deploying cloudflare-docs with
|
| Latest commit: |
a938004
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c3c58b58.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://dominik-update-python-for-sd.cloudflare-docs-7ou.pages.dev |
|
|
||
| if location: | ||
| return Response.redirect(location, 301) | ||
|
|
||
| # If request not in map, return the original request | ||
| return fetch(request) |
There was a problem hiding this comment.
Something that confused me while I was going through these examples: this line ends up creating an infinite loop of requests back to the worker. What's the intention behind this? Is there something I missed?
I changed it here to return a 404 as it seems to make most sense for this example, but there are other examples that use the same pattern. I left those largely alone.
There was a problem hiding this comment.
See https://developers.cloudflare.com/workers/configuration/routing/custom-domains/#interaction-with-routes for an explanation, this change should probably be reverted.
There was a problem hiding this comment.
Thanks. These examples should really call this pattern out. Getting an infinite loop on examples like this is really not a great dev experience when playing with these examples locally.
Maybe something for another PR
dom96
force-pushed
the
dominik/update-python-for-sdk
branch
from
7df4a10 to
e662fd3
Compare
|
dom96
force-pushed
the
dominik/update-python-for-sdk
branch
from
e662fd3 to
a938004
Compare
| @@ -61,19 +61,21 @@ export default { | |||
| </TabItem> <TabItem label="Python" icon="seti:python"> | |||
|
|
|||
| ```py | |||
| from js import Response, fetch, Headers, JSON, Promise | |||
| from cloudflare.workers import Response, fetch | |||
| import asyncio | |||
There was a problem hiding this comment.
This can be deployed even when packages not enabled?
The new Python SDK is now available in the latest version of Wrangler. It provides Python native implementations of classes like
Response.This PR modifies most of our Python examples to use the new APIs in the SDK.