Time travelling example in Typescript seems wrong

[finalyards]

Existing documentation URL(s)

https://developers.cloudflare.com/durable-objects/api/sqlite-storage-api/#onnextsessionrestorebookmark

What changes are you suggesting?

The "restore 2 days ago" doesn't seem right in Typescript.

let now = new Date();
// restore to 2 days ago
let bookmark = ctx.storage.getBookmarkForTime(now - 2);  // <-- 2ms
ctx.storage.onNextSessionRestoreBookmark(bookmark);

I'd use let bookmark = ctx.storage.getBookmarkForTime( new Date(now - (2 * 24 * 60 * 60 * 1000)) ), with or without the new Date. The current code substracts mere 2 milliseconds and also converts bookmark to be a number (which may be intended, not sure).

This is of course minor. Most people will realize to use the right syntax - I'm very impressed with the quality of Cloudflare's documentation.

Additional information

No response

[finalyards]

For comparison, here is another (correct) example:

[...]
const SECONDS = 1000;
[...]
   this.storage.setAlarm(Date.now() + 10 * SECONDS);
[...]

I like the use of Date.now(). With it, the original example would be:

const DAYS = 24*60*60*1000;

// restore to 2 days ago
let bookmark = ctx.storage.getBookmarkForTime(Date.now() - 2 * DAYS);
ctx.storage.onNextSessionRestoreBookmark(bookmark);

[sthefanydiogenes980-sys]

O meu está bugado

[Oxyjun]

Thanks so much @finalyards for flagging this. I've opened a PR to accept your suggestion.

Also, feel free to create a PR if you see docs that can be fixed / improved! We love having external contributors who care about improving docs.