Prevent crashing if no parameters defined in the schema #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now I see that this will be fixed here main...add-body-validation#diff-634333527025d8043fae2cc51a501b3e6cc4a200276c061bcaa0a947b0e9c3f1R105 probably |
|
Yeah, I fixed that bug in the #5 branch, but I think your proposed fix is more clean |
G4brym
approved these changes
Nov 25, 2022
|
I will bundle this fix with the next release when the request body validations are merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
OpenAPISchemainterface theparametersattribute is optional / can be undefined. However there's anObject.entries(params)that fails in that case.With this PR,
paramsis always defined andObject.entriesalways succeeds.Another option would've been to add an if statement. But this was the smallest change to make it work.