Merge pull request #1132 from asayyah/master

Fix race condition in revoke
cloudflare · Sep 25, 2020 · 8e907d3 · 8e907d3
2 parents 8090bce + 1b44b48
commit 8e907d3
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/revoke/revoke.go b/revoke/revoke.go
@@ -133,13 +133,13 @@ func getIssuer(cert *x509.Certificate) *x509.Certificate {
 // check a cert against a specific CRL. Returns the same bool pair
 // as revCheck, plus an error if one occurred.
 func certIsRevokedCRL(cert *x509.Certificate, url string) (revoked, ok bool, err error) {
+	crlLock.Lock()
 	crl, ok := CRLSet[url]
 	if ok && crl == nil {
 		ok = false
-		crlLock.Lock()
 		delete(CRLSet, url)
-		crlLock.Unlock()
 	}
+	crlLock.Unlock()
 
 	var shouldFetchCRL = true
 	if ok {