fix: protocol version validation in worker transport #720
+172
−181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove strict version matching after initialization. Now accepts any supported protocol version in request headers, or defaults to negotiated version when header is absent. Only rejects truly unsupported versions. - Remove unused imports (InitializeRequest) and local SUPPORTED_PROTOCOL_VERSIONS constant - Capture negotiated protocol version from initialize response instead of request - Simplify validateProtocolVersion to only reject
🦋 Changeset detectedLatest commit: 3f7016e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
9 tasks
Claude Code ReviewIssue in changeset: Typo - "isse" should be "issue" Architecture concern: The PR removes version tracking entirely but the comment in
Question: Is this intentional? If the SDK negotiates a version during initialization, should the transport enforce that specific version for the session lifetime, or is the stateless approach (accept any supported version at any time) the correct design? Otherwise the changes look good - simplifies the code, removes ~60 lines, and aligns with stateless transport goals. |
commit: |
agents-git-bot bot
pushed a commit
to cloudflare/cloudflare-docs
that referenced
this pull request
Dec 8, 2025
Sync documentation with cloudflare/agents PR #720: - Remove protocolVersion from TransportState interface (no longer stored) - Update protocol version validation behavior documentation - Clarify that protocol version validation is per-request, not session-bound The WorkerTransport now accepts any supported protocol version on each request or defaults to the negotiated version when header is absent, removing the need to track protocol version in persistent state. Related PR: cloudflare/agents#720 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
mattzcarey
changed the title
mattzcarey
changed the title
agents-git-bot bot
pushed a commit
to cloudflare/cloudflare-docs
that referenced
this pull request
Dec 8, 2025
Update documentation to reflect the simplified protocol version validation in WorkerTransport (cloudflare/agents#720). The transport now uses stateless validation that accepts any supported protocol version, rather than enforcing strict version consistency after negotiation. Changes: - Add new "Protocol version handling" section explaining stateless validation - Clarify that version headers are optional after initialization - Document that only unsupported versions are rejected Related PR: cloudflare/agents#720 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
whoiskatrin
approved these changes
Dec 8, 2025
agents-git-bot bot
pushed a commit
to cloudflare/cloudflare-docs
that referenced
this pull request
Dec 8, 2025
Sync from cloudflare/agents PR #720 Changes: - Remove protocolVersion field from TransportState interface (no longer stored) - Update persistent storage benefits to remove protocol version tracking - Add new Protocol Version Validation section explaining stateless validation approach The WorkerTransport now validates protocol version headers without tracking negotiated versions. It accepts any supported version or missing headers, only rejecting explicitly unsupported versions. Protocol negotiation is handled by the MCP SDK. Related: cloudflare/agents#720
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove strict version matching after initialization. Now accepts any supported protocol version in request headers and only rejects truly unsupported versions.
This aligns with the move to stateless transports/protocol
fixes: #719