Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka clarifications #599

Merged
merged 7 commits into from
Apr 21, 2020
Merged

Kafka clarifications #599

merged 7 commits into from
Apr 21, 2020

Conversation

clemensv
Copy link
Contributor

@clemensv clemensv commented Apr 1, 2020

Related to #571

Signed-off-by: clemensv clemensv@microsoft.com

clemensv and others added 5 commits April 2, 2020 17:53
Signed-off-by: clemensv <clemensv@microsoft.com>
Signed-off-by: clemensv <clemensv@microsoft.com>
Co-Authored-By: Manuel Stein <manuelstein@users.noreply.github.com>
Signed-off-by: clemensv <clemensv@microsoft.com>
Co-Authored-By: Manuel Stein <manuelstein@users.noreply.github.com>
Signed-off-by: clemensv <clemensv@microsoft.com>
Signed-off-by: clemensv <clemensv@microsoft.com>
@slinkydeveloper
Copy link
Member

Implementation in sdk-go: cloudevents/sdk-go#437

@duglin
Copy link
Collaborator

duglin commented Apr 16, 2020

@clemensv I think you pulled in one of subscription API docs by mistake

clemensv added 2 commits April 17, 2020 09:31
@duglin
Copy link
Collaborator

duglin commented Apr 21, 2020

Approved on 4/16 call

@duglin duglin merged commit b66172b into cloudevents:master Apr 21, 2020
n3wscott pushed a commit to n3wscott/cloudevents-spec that referenced this pull request Nov 30, 2020
* Draft for subscription API

Signed-off-by: clemensv <clemensv@microsoft.com>

* OpenAPI spec draft. Formatting changes,

Signed-off-by: clemensv <clemensv@microsoft.com>

* Update subscriptions-api.md

Co-Authored-By: Manuel Stein <manuelstein@users.noreply.github.com>
Signed-off-by: clemensv <clemensv@microsoft.com>

* Update subscriptions-api.md

Co-Authored-By: Manuel Stein <manuelstein@users.noreply.github.com>
Signed-off-by: clemensv <clemensv@microsoft.com>

* updates per feedback

Signed-off-by: clemensv <clemensv@microsoft.com>

* Kafka binding clarifications

Signed-off-by: clemensv <clemensv@microsoft.com>

Co-authored-by: clemensv <clemensv@microsoft.com>
Co-authored-by: Manuel Stein <manuelstein@users.noreply.github.com>
@duglin duglin mentioned this pull request Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants