Proprietary binding spec inclusion guide #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
specifications Signed-off-by: Day, Jeremy(jday) <jday@paypal.com>
duglin
reviewed
Mar 26, 2020
Signed-off-by: Day, Jeremy(jday) <jday@paypal.com>
bsideup
reviewed
Mar 26, 2020
- Subtle re-wording. - Added note requesting statement about supported versions Signed-off-by: Day, Jeremy(jday) <jday@paypal.com>
bsideup
reviewed
Mar 27, 2020
Signed-off-by: Day, Jeremy(jday) <jday@paypal.com>
Signed-off-by: Day, Jeremy(jday) <jday@paypal.com>
bsideup
approved these changes
Mar 27, 2020
|
LGTM thanks |
|
Approved on the 4/2 call |
n3wscott
pushed a commit
to n3wscott/cloudevents-spec
that referenced
this pull request
Nov 30, 2020
* Introduced language to guide the inclusion of proprietary binding specifications Signed-off-by: Day, Jeremy(jday) <jday@paypal.com> * Chnaged format to address review comment. Signed-off-by: Day, Jeremy(jday) <jday@paypal.com> * - Addressed review comment (referenced messaging based spec) - Subtle re-wording. - Added note requesting statement about supported versions Signed-off-by: Day, Jeremy(jday) <jday@paypal.com> * Fixed broekn link Signed-off-by: Day, Jeremy(jday) <jday@paypal.com> * Stylistic tweak... Signed-off-by: Day, Jeremy(jday) <jday@paypal.com> * Fix typo Signed-off-by: Day, Jeremy(jday) <jday@paypal.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced language to guide the inclusion of proprietary binding specifications
Signed-off-by: Day, Jeremy(jday) jday@paypal.com