Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding link to Pub/Sub binding #588

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Conversation

nachocano
Copy link
Contributor

  • Adding link to Google Cloud Pub/Sub binding in the proprietary specs file.

Signed-off-by: Nacho Cano <nachoacano@gmail.com>
@nachocano
Copy link
Contributor Author

To discuss in the next WG meeting. Thanks!

/assign @duglin @mikehelmick @n3wscott

@duglin
Copy link
Collaborator

duglin commented Mar 13, 2020

LGTM thanks!
And I did a quick scan of the spec itself, and it looks good too.

@nachocano
Copy link
Contributor Author

nachocano commented Mar 13, 2020 via email

@nachocano
Copy link
Contributor Author

@duglin can we get this one merged?

@duglin
Copy link
Collaborator

duglin commented Mar 23, 2020

Yup sorry - didn't get a chance to process the results of the previous meeting yet.... merging now.

@duglin duglin merged commit 29400c7 into cloudevents:master Mar 23, 2020
@duglin
Copy link
Collaborator

duglin commented Mar 23, 2020

Approved on the 3/19 call

@nachocano
Copy link
Contributor Author

nachocano commented Mar 23, 2020 via email

@duglin duglin mentioned this pull request Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants