Add CouchDB adapter specification #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionelvillard
force-pushed
the
couchdb
branch
from
dd845e1 to
c293850
Compare
Signed-off-by: Lionel Villard <villard@us.ibm.com>
lionelvillard
force-pushed
the
couchdb
branch
from
c293850 to
b371afc
Compare
duglin
reviewed
Oct 22, 2019
adapters/couchdb.md
Outdated
| | :-------------------- | :--------------------------------------- | | ||
| | `id` | The event sequence identifier (`seq`) | | ||
| | `source` | The server URL / db_name | | ||
| | `specversion` | `1.0-rc1` | |
There was a problem hiding this comment.
Let's be optimistic and make this 1.0 :-)
JemDay
reviewed
Oct 22, 2019
adapters/couchdb.md
Outdated
| | `specversion` | `1.0` | | ||
| | `type` | `org.apache.couchdb.document.update` | | ||
| | `datacontenttype` | `application/json` | | ||
| | `dataschema` | Omit | |
There was a problem hiding this comment.
If we're omitting this then i'd suggest removing the attribute completely.
adapters/couchdb.md
Outdated
| | `type` | `org.apache.couchdb.document.update` | | ||
| | `datacontenttype` | `application/json` | | ||
| | `dataschema` | Omit | | ||
| | `subject` | `id` value | |
There was a problem hiding this comment.
I assume this is the "Id" of the document that changed
There was a problem hiding this comment.
yes. Updating...
duglin
reviewed
Oct 22, 2019
adapters/couchdb.md
Outdated
| Each section below describes how to determine the CloudEvents attributes | ||
| based on the event type. | ||
|
|
||
| ## /db/_changes |
There was a problem hiding this comment.
I think the _ makes everything else after this show up in italics. I think if you escape it (e.g. \_) then it will fix that.
lionelvillard
force-pushed
the
couchdb
branch
from
601683c to
e2f128b
Compare
Signed-off-by: Lionel Villard <villard@us.ibm.com>
lionelvillard
force-pushed
the
couchdb
branch
from
e2f128b to
1c18aa4
Compare
Signed-off-by: Lionel Villard <villard@us.ibm.com>
|
Approved on 10/24 call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.