Remove lower-case restriction, lint. #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duglin
reviewed
Oct 7, 2019
|
LGTM if I can get one more LGTM we can merge since this is strictly syntax/typo fixes. |
deissnerk
reviewed
Oct 8, 2019
spec.md
Outdated
| All content attributes MUST be of scalar type (e.g. string, integer) | ||
| that have a string-encoding defined. They MUST NOT be of complex type | ||
| (e.g. structures, map). | ||
| All content attributes MUST be of scalar type (e.g. string, integer) that have a |
There was a problem hiding this comment.
Good eye!
@n3wscott want to get this one added to the PR?
|
rebase needed |
Signed-off-by: Scott Nichols <nicholss@google.com>
Signed-off-by: Doug Davis <dug@us.ibm.com>
|
ok - per Scott's request I rebased and made @deissnerk's s/content/context/ typo fix. Can I get one pair of eyes to review to make sure I didn't introduce another typo... then we can merge since it's just a minor typo type of PR? |
|
LGTM |
|
thanks @deissnerk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attribute names SHOULD begin with a lower-case letteras it was redundant.