Syntax fixes #506
Merged
Syntax fixes #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evan noticed we have more than one #data header so I tried to fix that. Also, we still used a complex/map in an example. Signed-off-by: Doug Davis <dug@us.ibm.com>
|
Perhaps we can approve this one off-line, if people review and LGTM it? |
Vlaaaaaaad
approved these changes
Sep 12, 2019
Renamed an example extension per Vlad's suggestion. Signed-off-by: Doug Davis <dug@us.ibm.com>
|
While looking for the text that describes what valid chars for attribute names, I found it near the terminology section - which seemed really odd. So I moved it into the "Context Attributes" section, so it'll be easier to find. I also renamed the 2nd extension example per Vlad's suggestion - just to have a bit of variety. |
|
Conditionally approved on the 9/12 call. No objections since then, so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evan noticed we have more than one #data header so I tried to fix that.
Also, we still used a complex/map in an example.
Signed-off-by: Doug Davis dug@us.ibm.com