Remove protobuf format until someone has time to redo it. #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that since proto binary encoding does not contain the keys, either something like the AVRO mapping (see #497), or something like the HTTP transport will be needed for the payload. I would suggest simply encoding the payload as Ideally, a CL that re-introduced this format would also include [gRPC][https://grpc.io] bindings. |
|
Since @erikerikson is AFK for a bit he asked me to complete this in a new PR. See: #507 |
bsideup
added a commit
to bsideup/liiklus
that referenced
this pull request
Feb 26, 2020
CloudEvents is an essential choice for Liiklus since it is the standard that we were missing when we created Liiklus. It introduces a clear notion of id, type and other fields that can be helpful for applying schema, RBAC, metrics and many other features At this stage, CloudEvents v1 is used as internal representation, and `LiiklusEvent` at the API level since there is no Protobuf format for CloudEvents yet: cloudevents/spec#504 `LiiklusEvent` follows the v1 of the spec. Once Protobuf definitions are available, we will deprecate `LiiklusEvent` and start using CloudEvent message type. oneof and format are there for a smooth migration. The implementation requires you to provide a plugin to "upcast" old events (use `RecordPreProcessor`/`RecordPostProcessor`). See `CloudEventsTest` for an example of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alas, poor proto... needs update for #492, and I don't have time.