Repository navigation
Add support for binary mode using NATS headers - #1016
Conversation
Headers were introduced in the NATS 2.2 release. Signed-off-by: Byron Ruth <b@devel.io>
|
@ColinSullivan1 Totally missed seeing the discussion in #975. If you or your team has a draft in place already I can close this, otherwise happy for this to be a starting point for edits. |
| @@ -1,4 +1,4 @@ | |||
| # NATS Protocol Binding for CloudEvents - Version 1.0.3-wip | |||
| # NATS Protocol Binding for CloudEvents - Version 1.0.4-wip | |||
There was a problem hiding this comment.
I think the version remains the same since we're still technically in the 1.0.3 cycle.
|
@bruth thanks! I don't know NATS but it looks pretty good (and thorough) to me. I think the href checker errors are real though. |
Signed-off-by: Byron Ruth <b@devel.io>
|
@duglin Thanks for the quick review. I fixed the links. |
Signed-off-by: Byron Ruth <b@devel.io>
|
@bruth, much appreciated - thank you! We had this on our list of TODO items but didn't get to this yet. LGTM! |
|
@ColinSullivan1 happy to help, thanks for the review! |
|
@duglin No rush, but is there anything remaining to do to get this merged? |
|
Nope - just need approval from the group. We normally approve PRs on the Thursday calls but we also allow for at least 3 days of review and this one just missed the deadline for this week's call. So unless something big shows up I expect it to be approved next Thursday. You can see it on the agenda here: https://docs.google.com/document/d/1OVF68rpuPK5shIHILK9JOqlZBbfe91RNzQ7u_P7YCDE/edit# |
|
Great thanks!
On May 13, 2022, GitHub Notifications ***@***.***> wrote:
Nope - just need approval from the group. We normally approve PRs on
the Thursday calls but we also allow for at least 3 days of review and
this one just missed the deadline for this week's call. So unless
something big shows up I expect it to be approved next Thursday. You
can see it on the agenda here:
<https://docs.google.com/document/d/1OVF68rpuPK5shIHILK9JOqlZBbfe91RNzQ7u_P7YCDE/edit#>
—
Reply to this email directly, view it on GitHub
<#1016 (comment)>,
or unsubscribe <https://github.com/notifications/unsubscribe-
auth/AAD5YRQYPDSJBL6RWLCB3LDVJ2QDVANCNFSM5VUSAS6Q>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@cloudevents/notify please review in prep for Thursday's call. |
|
Approved on the 5/19 call |
|
@duglin Great thanks! |
* Add support for binary mode using NATS headers Headers were introduced in the NATS 2.2 release. Signed-off-by: Byron Ruth <b@devel.io> * Address href errors and revert version bump Signed-off-by: Byron Ruth <b@devel.io> * Add missing href Signed-off-by: Byron Ruth <b@devel.io>
* Add support for binary mode using NATS headers Headers were introduced in the NATS 2.2 release. Signed-off-by: Byron Ruth <b@devel.io> * Address href errors and revert version bump Signed-off-by: Byron Ruth <b@devel.io> * Add missing href Signed-off-by: Byron Ruth <b@devel.io>
Fixes #975 #1006
Release Note
Reviewer Notes
/cc @derekcollison @duglin