fix: _json_or_string no longer fails on malformed unicode buffers
#184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasha-tkachev
changed the title
sasha-tkachev
changed the title
_json_or_string no longer fails on malformed unicode buffers
xSAVIKx
reviewed
Jul 20, 2022
There was a problem hiding this comment.
@sasha-tkachev please consider using standard AnyStr over custom typevar.
Also, can you please take care of adding appropriate docs to the function?
xSAVIKx
approved these changes
Jul 23, 2022
There was a problem hiding this comment.
@sasha-tkachev LGTM. Please fix the DCO and you should be good to go.
Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com>
Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com>
Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com>
Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com>
Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com>
for more information, see https://pre-commit.ci Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com>
Co-authored-by: Yurii Serhiichuk <xSAVIKx@users.noreply.github.com> Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com>
Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com>
Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com>
sasha-tkachev
force-pushed
the
bugfix/json-or-string-unicode-decode-issue
branch
from
2f4c86e
to
8525a95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #183
Changes
One line description for the changelog