-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: _json_or_string
no longer fails on malformed unicode buffers
#184
fix: _json_or_string
no longer fails on malformed unicode buffers
#184
Conversation
_json_or_string
no longer fails on malformed unicode buffers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sasha-tkachev please consider using standard AnyStr
over custom typevar.
Also, can you please take care of adding appropriate docs to the function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sasha-tkachev LGTM. Please fix the DCO and you should be good to go.
Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com>
Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com>
Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com>
Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com>
Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com>
for more information, see https://pre-commit.ci Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com>
Co-authored-by: Yurii Serhiichuk <xSAVIKx@users.noreply.github.com> Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com>
Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com>
Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com>
2f4c86e
to
8525a95
Compare
Fixes #183
Changes
One line description for the changelog