Skip to content

fix: merge strings on same line into single string #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 10, 2022

Conversation

hairmare
Copy link
Contributor

@hairmare hairmare commented Jan 6, 2022

Changes

Merges strings on same line into one string. Most likely these where reformatted from being multi-line strings.

One line description for the changelog

Simplify strings in HTTP JSON sample client

  • Tests pass
  • Appropriate changes to README are included in PR

Signed-off-by: Lucas Bickel hairmare@rabe.ch

Signed-off-by: Lucas Bickel <hairmare@rabe.ch>
Signed-off-by: Lucas <lucas.bickel@adfinis.com>
@xSAVIKx
Copy link
Member

xSAVIKx commented Jul 10, 2022

@hairmare, thx for your contribution. I guess this is already fixed as part of the bigger cleanup done in #167.

Please feel free to update your fork and check if this is still an issue.

@hairmare
Copy link
Contributor Author

@xSAVIKx i updated my fork, the change from #167 fixed 1 of the hunks that were in this PR, two hunks still remain

@xSAVIKx xSAVIKx merged commit 2896d04 into cloudevents:master Jul 10, 2022
@hairmare hairmare deleted the patch-1 branch July 10, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants