-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python 3.10 #150
Support Python 3.10 #150
Conversation
# web app tests | ||
sanic==20.12.3 | ||
sanic<=20.12.4; python_version <= '3.6' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious, how did you calculate this?
I am still developing my python knowledge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how @di calculated it, but looking at the git blame for the setup.py
file of the Sanic project, it's possible to see that Python 3.6 support was removed from Sanic on 2021 Feb 21.
That same commit adds the following line to the project README:
Minimum Python version is 3.7. If you need Python 3.6 support, please use v20.12LTS.
As of the time of this pull request, sanic==20.12.4
was the latest in the v20.12 line. Other micro versions have since been released in that LTS line, the latest as of today being sanic==20.12.6
.
I suppose this means that an alternative would be to specify instead this line as:
sanic<=20.12.4; python_version <= '3.6' | |
sanic~=20.12; python_version <= '3.6' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What else is missing before merging this branch and making a new release based on it?
I was considering including this library in a Python 3.10 project I'm working on.
# web app tests | ||
sanic==20.12.3 | ||
sanic<=20.12.4; python_version <= '3.6' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how @di calculated it, but looking at the git blame for the setup.py
file of the Sanic project, it's possible to see that Python 3.6 support was removed from Sanic on 2021 Feb 21.
That same commit adds the following line to the project README:
Minimum Python version is 3.7. If you need Python 3.6 support, please use v20.12LTS.
As of the time of this pull request, sanic==20.12.4
was the latest in the v20.12 line. Other micro versions have since been released in that LTS line, the latest as of today being sanic==20.12.6
.
I suppose this means that an alternative would be to specify instead this line as:
sanic<=20.12.4; python_version <= '3.6' | |
sanic~=20.12; python_version <= '3.6' |
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com> Signed-off-by: Dustin Ingram <di@users.noreply.github.com>
Signed-off-by: Dustin Ingram <di@users.noreply.github.com>
Signed-off-by: Dustin Ingram <di@users.noreply.github.com>
Signed-off-by: Dustin Ingram <di@users.noreply.github.com>
994541b
to
ec7643e
Compare
Fixes #145.