Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.10 #150

Merged
merged 4 commits into from
Apr 8, 2022
Merged

Support Python 3.10 #150

merged 4 commits into from
Apr 8, 2022

Conversation

di
Copy link
Member

@di di commented Dec 10, 2021

Fixes #145.

@di di requested a review from grant December 10, 2021 12:50
# web app tests
sanic==20.12.3
sanic<=20.12.4; python_version <= '3.6'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious, how did you calculate this?

I am still developing my python knowledge.

Copy link

@leorochael leorochael Mar 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how @di calculated it, but looking at the git blame for the setup.py file of the Sanic project, it's possible to see that Python 3.6 support was removed from Sanic on 2021 Feb 21.

That same commit adds the following line to the project README:

Minimum Python version is 3.7. If you need Python 3.6 support, please use v20.12LTS.

As of the time of this pull request, sanic==20.12.4 was the latest in the v20.12 line. Other micro versions have since been released in that LTS line, the latest as of today being sanic==20.12.6.

I suppose this means that an alternative would be to specify instead this line as:

Suggested change
sanic<=20.12.4; python_version <= '3.6'
sanic~=20.12; python_version <= '3.6'

Copy link

@leorochael leorochael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What else is missing before merging this branch and making a new release based on it?

I was considering including this library in a Python 3.10 project I'm working on.

# web app tests
sanic==20.12.3
sanic<=20.12.4; python_version <= '3.6'
Copy link

@leorochael leorochael Mar 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how @di calculated it, but looking at the git blame for the setup.py file of the Sanic project, it's possible to see that Python 3.6 support was removed from Sanic on 2021 Feb 21.

That same commit adds the following line to the project README:

Minimum Python version is 3.7. If you need Python 3.6 support, please use v20.12LTS.

As of the time of this pull request, sanic==20.12.4 was the latest in the v20.12 line. Other micro versions have since been released in that LTS line, the latest as of today being sanic==20.12.6.

I suppose this means that an alternative would be to specify instead this line as:

Suggested change
sanic<=20.12.4; python_version <= '3.6'
sanic~=20.12; python_version <= '3.6'

grant and others added 4 commits April 8, 2022 19:20
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>

Signed-off-by: Dustin Ingram <di@users.noreply.github.com>
Signed-off-by: Dustin Ingram <di@users.noreply.github.com>
Signed-off-by: Dustin Ingram <di@users.noreply.github.com>
Signed-off-by: Dustin Ingram <di@users.noreply.github.com>
@duglin duglin merged commit 2e5b96b into cloudevents:master Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add python 3.10 support
4 participants