0.2 force improvements #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Makogon <denys.makogon@oracle.com>
- this method validates whether a converter can process the event, in case of structured converter this method does nothing, in case of binary converter this method raise an exception if an event is not v0.2 - adding (un)marshaller validation on being a callable object - tests added Signed-off-by: Denis Makogon <denys.makogon@oracle.com>
Signed-off-by: Evan Anderson <argent@google.com>
Signed-off-by: Evan Anderson <argent@google.com>
Updates for binary encoding
|
@evankanderson are we good merging and releasing this? |
|
It looks like this passes tests, so it makes sense to me to release. Do you want to push this change to |
|
yeah, i'll push that into a stable branch, but not it v0.2.0-stable, because vX.X.X is related to pypi release the version of which will be 0.2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge of #7 and #9