Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog doesn't reflect v02/v01 removal #45

Closed
cumason123 opened this issue Jun 22, 2020 · 7 comments
Closed

Changelog doesn't reflect v02/v01 removal #45

cumason123 opened this issue Jun 22, 2020 · 7 comments

Comments

@cumason123
Copy link
Contributor

Expected Behavior

Changelog should explain why versions v02 and v01 were removed

Actual Behavior

Changelog wasn't updated in that PR

Steps to Reproduce the Problem

View the changelog

Specifications

  • Platform: any
@cumason123
Copy link
Contributor Author

@di should changelog adjustments go in the PR which makes the change or separate PR's? Just wanna know how I should merge in the changelog adjustment

@cumason123
Copy link
Contributor Author

Furthermore, should I just add YANKED to every version of 0.2 and 0.1? I'm unsure what the format is for yanking an entire version.

@di
Copy link
Member

di commented Jun 22, 2020

Ideally they would be in the PR that makes the changes, with a link to the corresponding issue.

@di
Copy link
Member

di commented Jun 22, 2020

Furthermore, should I just add YANKED to every version of 0.2 and 0.1? I'm unsure what the format is for yanking an entire version.

Not sure I follow. Why would we be yanking these versions?

@cumason123
Copy link
Contributor Author

So we removed versions v0.1 and v0.2. I'm unsure how to modify a changelog to reflect those changes (my first time modifying a changelog).

@di
Copy link
Member

di commented Jun 22, 2020

We removed support for the v0.1 and v0.2 specifications. The releases on PyPI, while they have the same version numbers, are independent from the spec versions, and should remain.

I would expect to see something like the following in the changelog:

Remove support for CloudEvents v0.1 and v0.2 specs (#35)

@cumason123
Copy link
Contributor Author

Thanks, I was confused on what version referred to what. Rookie mistake!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants