Set correct url to naming conventions.

[gklijs]

I noticed the url in the Java doc was not correct. As it turns out using a regex is about ten times slower for this case, so I removed that part of the commit.

[pierDipi]

also think it would be preferable to use a regex for validating the extension name.

Would you mind expanding on the why?

[gklijs]

It might be faster, although, with the expected small size of an extension name, that might not be the case. It does limit the lines of code, but the complexity of a regex might outweigh that.

[pierDipi]

It might be faster, although, with the expected small size of an extension name, that might not be the case. It does limit the lines of code, but the complexity of a regex might outweigh that.

Exactly, a proper benchmark should be added to validate the change isn't a perf regression for various cases.

[gklijs]

Thanks, I learned something today. Using the 3 extension names used in the unit test I quickly created a JMH test.

Result "io.cloudevents.bench.core.ValidExtensionNameBenchmark.validateUsingRegex":
  6191804.624 ±(99.9%) 144293.900 ops/s [Average]
  (min, avg, max) = (5863269.600, 6191804.624, 6608794.307), stdev = 192628.228
  CI (99.9%): [6047510.724, 6336098.524] (assumes normal distribution)

Result "io.cloudevents.bench.core.ValidExtensionNameBenchmark.validateUsingLoop":
  39559968.737 ±(99.9%) 1142943.753 ops/s [Average]
  (min, avg, max) = (35967212.664, 39559968.737, 40975142.182), stdev = 1525797.210
  CI (99.9%): [38417024.985, 40702912.490] (assumes normal distribution)

As the for loop implementation is almost 7 times faster, I reverted that part of the commit.

[pierDipi]

Hi @gklijs, thanks for the fix and the quick update, can you please fix the DCO check as explained here: https://github.com/cloudevents/sdk-java/pull/477/checks?check_run_id=8348631721?

[gklijs]

Should be good now.

[pierDipi]

Thanks @gklijs!

LGTM