Skip to content

[CESQL] Constant folding #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
slinkydeveloper merged 6 commits into from
Jun 4, 2021
Merged

[CESQL] Constant folding #392

slinkydeveloper merged 6 commits into from
Jun 4, 2021

Conversation

@slinkydeveloper
Copy link
Member

@slinkydeveloper slinkydeveloper commented May 17, 2021 •
edited
Loading

This PR includes:

  • A new visitor to visit the ExpressionInternal tree and mutate it, in order to execute some manipulations (like the constant folding)
  • Introduced BaseUnaryExpression to simplify a bit the visitor thing
  • Implemented ConstantFoldingExpressionVisitor to perform the constant folding
  • Moved ExpressionInternal in expressions package
  • Added some tests covering both the tck with constant folding enabled and with constant folding disabled

In the next PRs I'll reorganize a bit the code in more packages, in order to avoid the mess we have now

@slinkydeveloper
Added visitor for the expressions
312218c 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
First constant folding draft
614cdcd 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper slinkydeveloper added the enhancement New feature or request label May 17, 2021
@slinkydeveloper slinkydeveloper added this to the 2.2 milestone May 17, 2021
@slinkydeveloper
Copy link
Member Author

slinkydeveloper commented May 17, 2021

To simplify the review of the PR, I can split in several PRs

@slinkydeveloper
Constant folding for unary expressions
7a96649 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
More testing
2dc5ff3 
Constant folding for exists expression

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Little mistake
38f431e 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper slinkydeveloper changed the title [WIP][CESQL] Constant folding [CESQL] Constant folding May 18, 2021
pierDipi
pierDipi approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

LGTM

@slinkydeveloper
Added a ParserBuilder
31acdb1 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper slinkydeveloper merged commit a0b0835 into cloudevents:master Jun 4, 2021
@slinkydeveloper slinkydeveloper deleted the constant_folding branch June 4, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierDipi pierDipi pierDipi approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

2.2

Development

Successfully merging this pull request may close these issues.

2 participants

@slinkydeveloper @pierDipi