Javadocs api and core #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slinkydeveloper
force-pushed
the
fixing_javadocs_external_links
branch
from
573b60d to
18945ab
Compare
matejvasek
reviewed
Dec 1, 2020
matejvasek
reviewed
Dec 1, 2020
core/src/main/java/io/cloudevents/core/extensions/impl/ExtensionUtils.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
matejvasek
reviewed
Dec 1, 2020
core/src/main/java/io/cloudevents/core/message/MessageReader.java
Outdated
Show resolved
Hide resolved
matejvasek
reviewed
Dec 1, 2020
|
|
||
| /** | ||
| * Visit the message as structured encoded event using the provided visitor | ||
| * Read the message as structured encoded message using the provided reader |
slinkydeveloper
force-pushed
the
fixing_javadocs_external_links
branch
from
5362f88 to
362e1bd
Compare
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
matejvasek
reviewed
Dec 1, 2020
core/src/main/java/io/cloudevents/core/message/MessageReader.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
matejvasek
reviewed
Dec 1, 2020
| <T> T read(StructuredMessageWriter<T> visitor) throws CloudEventRWException, IllegalStateException; | ||
| <R> R read(StructuredMessageWriter<R> writer) throws CloudEventRWException, IllegalStateException; | ||
|
|
||
| default CloudEvent toEvent() throws CloudEventRWException, IllegalStateException { |
Contributor
There was a problem hiding this comment.
I see these two methods are documented in extending interface. Why?
Contributor
There was a problem hiding this comment.
I mean the toEvent() methods.
Member
Author
There was a problem hiding this comment.
I expect the user to look in this interface for this method, not in StructuredMessageReader. Does that makes sense?
matejvasek
reviewed
Dec 9, 2020
core/src/main/java/io/cloudevents/core/message/MessageReader.java
Outdated
Show resolved
Hide resolved
matejvasek
reviewed
Dec 9, 2020
matejvasek
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a lot of new javadocs for api and core
Also:
Signed-off-by: Francesco Guardiani francescoguard@gmail.com