Skip to content

Examples readme #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
slinkydeveloper merged 3 commits into from
Nov 24, 2020
Merged

Examples readme #298

slinkydeveloper merged 3 commits into from
Nov 24, 2020

Conversation

@slinkydeveloper
Copy link
Member

@slinkydeveloper slinkydeveloper commented Nov 24, 2020 •
edited
Loading

  • Also improved the quarkus example to use the new CloudEventData api
  • Also added to the root readme amqp and http basic

@slinkydeveloper slinkydeveloper added enhancement New feature or request documentation labels Nov 24, 2020
@slinkydeveloper slinkydeveloper added this to the 2.0.0.RC1 milestone Nov 24, 2020
pierDipi
pierDipi reviewed Nov 24, 2020
View reviewed changes
@slinkydeveloper
Added readme
04b93b0 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Improved the quarkus example
da8a9bd 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Added amqp proton
303c0af 
Fixed and added stuff to the root readme
Added link to examples readme to the main readme

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Copy link
Member Author

slinkydeveloper commented Nov 24, 2020

@Alfusainey wanna check this one?

Alfusainey
Alfusainey approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@Alfusainey Alfusainey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slinkydeveloper slinkydeveloper merged commit d2a89a4 into cloudevents:master Nov 24, 2020
@slinkydeveloper slinkydeveloper deleted the readme_examples branch November 24, 2020 09:17
@slinkydeveloper slinkydeveloper mentioned this pull request Nov 26, 2020
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierDipi pierDipi pierDipi left review comments

+1 more reviewer

@Alfusainey Alfusainey Alfusainey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation enhancement New feature or request

Projects

None yet

Milestone

2.0.0.RC1

Development

Successfully merging this pull request may close these issues.

3 participants

@slinkydeveloper @Alfusainey @pierDipi