Add AMQP example #294
Merged
Add AMQP example #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
slinkydeveloper
left a comment
slinkydeveloper
left a comment
There was a problem hiding this comment.
Mostly stylistic comments, looks good!
examples/amqp/src/main/java/io/cloudevents/examples/amqp/vertx/AmqpClient.java
Outdated
Show resolved
Hide resolved
examples/amqp/src/main/java/io/cloudevents/examples/amqp/vertx/AmqpClient.java
Outdated
Show resolved
Hide resolved
examples/amqp/src/main/java/io/cloudevents/examples/amqp/vertx/AmqpClient.java
Outdated
Show resolved
Hide resolved
examples/amqp/src/main/java/io/cloudevents/examples/amqp/vertx/AmqpClient.java
Outdated
Show resolved
Hide resolved
examples/amqp/src/main/java/io/cloudevents/examples/amqp/vertx/AmqpClient.java
Outdated
Show resolved
Hide resolved
examples/amqp/src/main/java/io/cloudevents/examples/amqp/vertx/AmqpClient.java
Show resolved
Hide resolved
slinkydeveloper
approved these changes
Nov 24, 2020
Member
|
Can you resolve the conflicts so we can merge? |
Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey
force-pushed
the
amqp-example
branch
from
e77cebb to
8f631da
Compare
Signed-off-by: Alfusainey Jallow <alf.jallow@gmail.com>
Alfusainey
force-pushed
the
amqp-example
branch
from
8f631da to
afa75d8
Compare
Contributor
Author
done! also renamed the module name in examples parent module to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An example demonstrating how the amqp 1.0 binding for cloud events can used.
The example uses the vertx-proton wrapper. The reason is that the wrapper makes it relatively easy to create amqp clients/servers. Secondly, its a wrapper around qpid-protonj which means that it can be used together with the amqp binding for cloud events. Third, the vertx-proton wrapper is commonly used in IoT setups that leverages AMQP for their messaging.
Signed-off-by: Alfusainey Jallow alf.jallow@gmail.com