Skip to content

Add sources plugin to Maven build #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
slinkydeveloper merged 1 commit into from
Nov 18, 2020
Merged

Add sources plugin to Maven build #284

slinkydeveloper merged 1 commit into from
Nov 18, 2020

Conversation

@dsyer
Copy link
Contributor

@dsyer dsyer commented Nov 18, 2020

It's nice to have sources in the IDE.

slinkydeveloper
slinkydeveloper reviewed Nov 18, 2020
View reviewed changes
Copy link
Member

@slinkydeveloper slinkydeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, I have just a small comment about this

pom.xml
</executions>
</plugin>
<!-- Sources jar -->
<plugin>
Copy link
Member

@slinkydeveloper slinkydeveloper Nov 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have this in the release profile, do we need it 2 times?

Copy link
Contributor Author

@dsyer dsyer Nov 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice, sorry. Why would you want it in a profile though? If I just mvn clean install locally, I would want to see sources. Can I remove it from the profile?

Copy link
Contributor Author

@dsyer dsyer Nov 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing the profile doesn't get used for snapshots? That's why I didn't see any sources. IMO it should be in the default profile (so I made that change in the PR now).

Copy link
Member

@slinkydeveloper slinkydeveloper Nov 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can remove it from the profile. The release profile is used both for snapshots and production releases

Copy link
Member

@slinkydeveloper slinkydeveloper Nov 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok as is now it's fine

@slinkydeveloper slinkydeveloper added the enhancement New feature or request label Nov 18, 2020
@slinkydeveloper slinkydeveloper added this to the 2.0.0.CR1 milestone Nov 18, 2020
Add sources plugin to Maven build
ac85417 
Signed-off-by: Dave Syer <dsyer@vmware.com>
@slinkydeveloper slinkydeveloper merged commit 8ac23dc into cloudevents:master Nov 18, 2020
@slinkydeveloper
Copy link
Member

slinkydeveloper commented Nov 18, 2020

Thanks for the contribution!

@dsyer dsyer deleted the sources branch November 18, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slinkydeveloper slinkydeveloper slinkydeveloper left review comments

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

2.0.0.RC1

Development

Successfully merging this pull request may close these issues.

2 participants

@dsyer @slinkydeveloper