CloudEventBuilder should fail when providing an invalid extension name #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arghya88
force-pushed
the
validate-extension-name
branch
2 times, most recently
from
7ffbbae to
13e96a0
Compare
core/src/test/java/io/cloudevents/core/CloudEventUtilsTest.java
Outdated
Show resolved
Hide resolved
arghya88
force-pushed
the
validate-extension-name
branch
2 times, most recently
from
19a0c78 to
14038ac
Compare
Contributor
Author
|
@slinkydeveloper changes done.PTAL |
Member
slinkydeveloper
left a comment
slinkydeveloper
left a comment
There was a problem hiding this comment.
small nit and we're good to go
core/src/main/java/io/cloudevents/core/impl/BaseCloudEventBuilder.java
Outdated
Show resolved
Hide resolved
slinkydeveloper
added
enhancement
Signed-off-by: Arghya Sadhu <arghya88@gmail.com>
arghya88
force-pushed
the
validate-extension-name
branch
from
14038ac to
cd4988c
Compare
Member
|
Thanks for your contribution @arghya88! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arghya Sadhu arghya88@gmail.com
Fixes #271