fix javadoc #274
Merged
fix javadoc #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matej Vasek <mvasek@redhat.com>
Member
|
Did you tried to run the maven javadoc plugin locally? since you're here, can you enable it for the whole build so we make sure we catch those issues next time before merging? |
Contributor
Author
|
I did run javadoc build. |
Contributor
Author
|
@slinkydeveloper we could move javadoc plugin up diff --git a/pom.xml b/pom.xml
index 1185628..30b7d4b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -142,6 +142,22 @@
</plugin>
</plugins>
</pluginManagement>
+ <plugins>
+ <!-- Javadoc jar -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-javadoc-plugin</artifactId>
+ <version>2.10.4</version>
+ <executions>
+ <execution>
+ <id>attach-javadocs</id>
+ <goals>
+ <goal>jar</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
</build>
<profiles>
@@ -198,22 +214,6 @@
</execution>
</executions>
</plugin>
-
- <!-- Javadoc jar -->
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-javadoc-plugin</artifactId>
- <version>2.10.4</version>
- <executions>
- <execution>
- <id>attach-javadocs</id>
- <goals>
- <goal>jar</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
-
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-gpg-plugin</artifactId> |
Member
|
What do you mean? Can you commit this change? |
Contributor
Author
Member
|
Cool, I'm gonna merge this one meanwhile |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.