[#30] Implement AMQP 1.0 transport binding

[Alfusainey]

An initial patch implementing the AMQP 1.0 protocol binding for cloud events. This patch implements the MessageReader and MessageWriter interfaces to support the reading and writing of cloud events to and from an AMQP representation

@slinkydeveloper I did a demo integration test using a vertx-proton client and server to send and receive cloud event messages. once this is merged, i will provide a sample README

Signed-off-by: Alfusainey Jallow alf.jallow@gmail.com

[slinkydeveloper]

This PR looks reaaaally nice and I'm super excited about it, thanks for your contribution!!!

I left a bunch of questions and style comments. Sorry in advance for the comments related to my poor knowledge of amqp 😄

[matzew]

REally nice work! Glad to see this coming!

[Alfusainey]

i updated the PR to incorporate the comments. i also renamed the class names to include Proton so that it is clear which amqp library the implementation uses

[slinkydeveloper]

Small nits and we can merge

[Alfusainey]

@slinkydeveloper unfortunately, i have to add -Dmaven.javadoc.skip=true to skip building the javadoc locally since not all APIs in this project have proper Javadoc comments (this was added in revision 554198d). I feel that adding the comments in PR may distract from the original issue we are solving here. WDYT?

[slinkydeveloper]

@Alfusainey I'm looking now at the errors and it seems they're related to this pr, let me show you

[Alfusainey]

@Alfusainey I'm looking now at the errors and it seems they're related to this pr, let me show you

@slinkydeveloper the build is actually failing to generate javadoc for the cloudevents-api module. here is a summary:

[ERROR] Exit code: 1 - javadoc: error - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] sdk-java/api/src/main/java/io/cloudevents/CloudEvent.java:31: warning: no @return
[ERROR]     CloudEventData getData();
[ERROR]                    ^
[ERROR] sdk-java/api/src/main/java/io/cloudevents/rw/CloudEventReader.java:38: warning: no @param for <V>
[ERROR]     default <V extends CloudEventWriter<R>, R> R read(CloudEventWriterFactory<V, R> writerFactory) throws CloudEventRWException {
[ERROR]                                                  ^
[ERROR] sdk-java/api/src/main/java/io/cloudevents/rw/CloudEventReader.java:38: warning: no @param for <R>
[ERROR]     default <V extends CloudEventWriter<R>, R> R read(CloudEventWriterFactory<V, R> writerFactory) throws CloudEventRWException {
[ERROR]                                                  ^
[ERROR] sdk-java/api/src/main/java/io/cloudevents/rw/CloudEventReader.java:38: warning: no @return
[ERROR]     default <V extends CloudEventWriter<R>, R> R read(CloudEventWriterFactory<V, R> writerFactory) throws CloudEventRWException {
[ERROR]                                                  ^
[ERROR] sdk-java/api/src/main/java/io/cloudevents/rw/CloudEventReader.java:45: warning: no @param for <V>
[ERROR]     <V extends CloudEventWriter<R>, R> R read(CloudEventWriterFactory<V, R> writerFactory, @Nullable CloudEventDataMapper mapper) throws CloudEventRWException;
[ERROR]                                          ^
[ERROR] sdk-java/api/src/main/java/io/cloudevents/rw/CloudEventReader.java:45: warning: no @param for <R>
[ERROR]     <V extends CloudEventWriter<R>, R> R read(CloudEventWriterFactory<V, R> writerFactory, @Nullable CloudEventDataMapper mapper) throws CloudEventRWException;

any idea what am doing wrong?

[Alfusainey]

i needed to modify the maven-javadoc-plugin configuration for the build to work for me (https://stackoverflow.com/a/61884267/8462878). i will not commit this change though :-)

[slinkydeveloper]

@slinkydeveloper the build is actually failing to generate javadoc for the cloudevents-api module

So on your machine javadoc tool fails for warnings? Interesting... Anyway, we plan to fix javadoc properly soon #264 so hopefully this will be fixed asap.

[slinkydeveloper]

@Alfusainey thanks again for this contribution 🚀

[Alfusainey]

@Alfusainey thanks again for this contribution 🚀

you're welcome, and thanks a lot for taking the time to review it! I will be hanging around this project from now on 😄

[slinkydeveloper]

Oh yeah, feel free to check out the other good first issues https://github.com/cloudevents/sdk-java/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 and also join the cncf slack if you want to https://cloud-native.slack.com/archives/CCXF3CBL1