Improvements to CloudEventReader #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added CloudEventUtils#toContextReader to create a context reader starting from a CloudEvent Improved documentation of *Reader interfaces Renamed MessageReader#visit to the proper name MessageReader#read Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
matejvasek
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readAttributesandreadExtensionsfromCloudEventReaderand moved toCloudEventContextReader: This relaxes the assumption that anyCloudEventReaderhas attributes and extensions buffered and it avoids to create empty implementations ofreadAttributes/readExtensionsfor protocol bindings (in protocol bindings context, onlyreadis ever used).CloudEventUtils#toContextReaderto create a context reader starting from aCloudEvent(in fact, works the same asCloudEventUtils#toVisitableMessageReader#visitto the proper nameMessageReader#readSigned-off-by: Francesco Guardiani francescoguard@gmail.com