Moved CloudEventUtils to io.cloudevents.core #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejvasek
approved these changes
Nov 12, 2020
Renamed CloudEventUtils#toVisitable to CloudEventUtils#toReader Added CloudEventUtils#toEvent Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
slinkydeveloper
force-pushed
the
utils
branch
from
ed7afbd to
96be516
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
CloudEventUtilsnow contains utilities useful to deal with conversions, often useful for end users of the sdk (look atmapData), I think it's reasonable to make it more visible and push it in the main packagecloudevents-core.Also:
CloudEventUtils#toVisitabletoCloudEventUtils#toReaderCloudEventUtils#toEventmethods to convert aCloudEventReaderto aCloudEventSigned-off-by: Francesco Guardiani francescoguard@gmail.com