Skip to content

Json mapper #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
slinkydeveloper merged 5 commits into from
Nov 11, 2020
Merged

Json mapper #258

slinkydeveloper merged 5 commits into from
Nov 11, 2020

Conversation

@slinkydeveloper
Copy link
Member

@slinkydeveloper slinkydeveloper commented Nov 10, 2020

Implemented a CloudEventDataMapper and a CloudEventData that uses jackson json mapper to map CloudEventData to pojos

@slinkydeveloper slinkydeveloper added the enhancement New feature or request label Nov 10, 2020
@slinkydeveloper slinkydeveloper mentioned this pull request Nov 10, 2020
Merged
@aliok
Copy link

aliok commented Nov 10, 2020

/lgtm

Sensible follow up for #257

@slinkydeveloper slinkydeveloper added this to the 2.0.0-milestone5 milestone Nov 10, 2020
@johanhaleby
Copy link
Contributor

johanhaleby commented Nov 11, 2020 •
edited
Loading

I think this looks fine as well! It's in the jackson package and people are used to deal with generics when working with Jackson.

@slinkydeveloper
Implemented Pojo mapper using jackson
0d11a28 
Added other exception kinds

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Fixup for the rebase
6b9786e 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Removed comment
a73c00f 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Equals and hash code
e6a0770 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
pierDipi
pierDipi approved these changes Nov 11, 2020
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slinkydeveloper
Fixed rebase issues
cb4aade 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper slinkydeveloper merged commit c7baada into cloudevents:master Nov 11, 2020
@slinkydeveloper slinkydeveloper deleted the json_mapper branch November 11, 2020 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierDipi pierDipi pierDipi approved these changes

+1 more reviewer

@aliok aliok aliok left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

2.0.0.RC1

Development

Successfully merging this pull request may close these issues.

4 participants

@slinkydeveloper @aliok @johanhaleby @pierDipi