Switch ZonedDateTime to OffsetDateTime
#216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slinkydeveloper
force-pushed
the
issues/214
branch
from
2d86c5a to
b035af1
Compare
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
slinkydeveloper
force-pushed
the
issues/214
branch
from
b035af1 to
6ab0f92
Compare
pwall-tyro
reviewed
Sep 1, 2020
pwall-tyro
approved these changes
Sep 1, 2020
pwall-tyro
left a comment
pwall-tyro
left a comment
There was a problem hiding this comment.
Thank you for taking my suggestion on board. I have made a recommendation that may simplify the code a little further, but I am happy to approve the changes in any case.
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Member
Author
|
@pwall-tyro can you check it again? 😄 |
matejvasek
reviewed
Sep 29, 2020
| Arguments.of("1990-12-31T15:59:00-08:00"), | ||
| Arguments.of("1937-01-01T12:00:27.87+00:20") | ||
| Arguments.of("1985-04-12T23:20:50.520Z"), | ||
| Arguments.of("1990-12-31T23:59Z"), |
Contributor
There was a problem hiding this comment.
@slinkydeveloper is this a valid RFC3339 date if there are no seconds?
Member
Author
There was a problem hiding this comment.
I was looking at the abnf, it seems like i made a mistake here
partial-time = time-hour ":" time-minute ":" time-second
[time-secfrac]
full-date = date-fullyear "-" date-month "-" date-mday
full-time = partial-time time-offset
partial-time has mandatory time-second
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #214
There is also a small change that prevented travis to correctly build the module (while building, the cache was using an old version of cloudevents-api)
Signed-off-by: Francesco Guardiani francescoguard@gmail.com
Mind giving a look @pwall-tyro ?