Patch sarama_kafka rebalance fix #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: cloudevents#817 Issue Explanation: IBM/sarama#2118 Fix reference: https://github.com/Shopify/sarama/blob/5e2c2ef0e429f895c86152189f625bfdad7d3452/examples/consumergroup/main.go#L177 Signed-off-by: nbajaj90 <nbajaj90@gmail.com>
nbajaj90
force-pushed
the
patch_sarama_kafka_rebalance_fix
branch
from
9d45161
to
01c4f13
Compare
|
LGTM |
embano1
reviewed
Nov 8, 2022
embano1
reviewed
Nov 8, 2022
Signed-off-by: nbajaj90 <nbajaj90@gmail.com>
nbajaj90
requested review from
lionelvillard and
embano1
and removed request for
lionelvillard and
embano1
Signed-off-by: nbajaj90 <nbajaj90@gmail.com>
|
LGTM waiting for @embano1 for final review. |
Signed-off-by: nbajaj90 <nbajaj90@gmail.com>
embano1
approved these changes
Nov 9, 2022
|
Approved |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #817
Issue Explanation and Fix: IBM/sarama#2118
Fix reference: https://github.com/Shopify/sarama/blob/5e2c2ef0e429f895c86152189f625bfdad7d3452/examples/consumergroup/main.go#L177