Update to use Apache Thrift everywhere, instead of using thriftpy on Python 3. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewwardrop
force-pushed
the
mw_migrate_to_apache_thrift
branch
3 times, most recently
from
c909819 to
fa7ed21
Compare
matthewwardrop
force-pushed
the
mw_migrate_to_apache_thrift
branch
from
fa7ed21 to
139b243
Compare
|
Hi @wesm. Merging this in now... But can you organise a release? Or set up travis auto-releasing? Or add me as a maintainer on PyPI? |
|
@wesm Ping! |
|
I just made you an owner on PyPI. Sorry for the delay! |
|
Thanks @wesm, and no worries :). |
andreypolyak
added a commit
to andreypolyak/thrift_sasl
that referenced
this pull request
May 5, 2018
…ftpy on Python 3. (cloudera#6)" This reverts commit 6b91721.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @wesm on a PR to impyla: cloudera/impyla#251, here is an update to use Apache thrift everywhere.
Fully tested downstream in
pyhiveunit tests.