Make sure we read all data in _read_frame() and _recv_sasl_message() #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- self._trans.read() usually makes no attempt to read all data, so use readAll() instead - Keep the compatibility layer with thriftpy, as readAll does not exist there, only read, which functions the same as readAll Fixes cloudera#22
Lordshinjo
force-pushed
the
fix_read_readall
branch
from
e1948a2 to
5b8aeb9
Compare
|
@dknupp is this something you can merge, as it's a bug which was introduced in 0.41 |
Thanks @NielsZeilemaker -- tested to confirm this works. Thank you for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readAll() instead
there, only read, which functions the same as readAll
Fixes #22